Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: failures messages for freezed item login schema #551

Merged
merged 1 commit into from
Sep 25, 2024
Merged

feat: failures messages for freezed item login schema #551

merged 1 commit into from
Sep 25, 2024

Conversation

Defferrard
Copy link
Contributor

No description provided.

@Defferrard Defferrard linked an issue Sep 25, 2024 that may be closed by this pull request
Cannot sign in freezed item login schema #550
Closed
@Defferrard Defferrard self-assigned this Sep 25, 2024
pyphilia
pyphilia requested changes Sep 25, 2024
View reviewed changes
Copy link
Contributor

@pyphilia pyphilia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I suggest more precise message & variables, otherwise it is good!

src/constants/messages.ts Outdated Show resolved Hide resolved
src/langs/en/messages.json Outdated Show resolved Hide resolved
@Defferrard Defferrard force-pushed the 550-cannot-sign-in-freezed-item-login-schema branch from 6cb161a to a0fc404 Compare September 25, 2024 09:04
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@Defferrard Defferrard requested a review from pyphilia September 25, 2024 09:06
@pyphilia pyphilia added this pull request to the merge queue Sep 25, 2024
Merged via the queue into main with commit 0e02dca Sep 25, 2024
3 checks passed
@graasper graasper mentioned this pull request Sep 25, 2024
Merged
@spaenleh spaenleh deleted the 550-cannot-sign-in-freezed-item-login-schema branch October 2, 2024 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pyphilia pyphilia pyphilia approved these changes

@ReidyT ReidyT Awaiting requested review from ReidyT

Assignees

@Defferrard Defferrard

Labels
v1.39.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot sign in freezed item login schema
2 participants
@Defferrard @pyphilia