Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add membership request related translations #540

Merged
merged 4 commits into from
Sep 23, 2024
Merged

feat: add membership request related translations #540

merged 4 commits into from
Sep 23, 2024

Conversation

pyphilia
Copy link
Contributor

No description provided.

@pyphilia pyphilia marked this pull request as ready for review September 23, 2024 07:28
Defferrard
Defferrard approved these changes Sep 23, 2024
View reviewed changes
Copy link
Contributor

@Defferrard Defferrard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

I think we should refactor the Graasp Translation so we use dynamic imports, and we don't list all our files..

ReidyT
ReidyT approved these changes Sep 23, 2024
View reviewed changes
Copy link
Contributor

@ReidyT ReidyT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just take a look at my suggestions.

src/langs/en/messages.json Outdated Show resolved Hide resolved
src/langs/fr/messages.json Outdated Show resolved Hide resolved
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@pyphilia pyphilia enabled auto-merge September 23, 2024 12:33
@pyphilia pyphilia added this pull request to the merge queue Sep 23, 2024
Merged via the queue into main with commit efd9430 Sep 23, 2024
3 checks passed
@graasper graasper mentioned this pull request Sep 23, 2024
Merged
@spaenleh spaenleh deleted the membership-request branch October 2, 2024 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ReidyT ReidyT ReidyT approved these changes

@Defferrard Defferrard Defferrard approved these changes

Assignees
No one assigned
Labels
v1.38.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pyphilia @Defferrard @ReidyT