Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: item login exist error message #516

Merged
merged 1 commit into from
Sep 11, 2024
Merged

feat: item login exist error message #516

merged 1 commit into from
Sep 11, 2024

Conversation

Defferrard
Copy link
Contributor

No description provided.

@Defferrard Defferrard linked an issue Aug 29, 2024 that may be closed by this pull request
failure message when item login schema exists #515
Closed
@Defferrard Defferrard self-assigned this Aug 29, 2024
ReidyT
ReidyT reviewed Aug 29, 2024
View reviewed changes
Copy link
Contributor

@ReidyT ReidyT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure the message is really understandable for a user 😅. I don't have the whole context right now, so I haven't suggest something else ^^

src/langs/en/messages.json Outdated Show resolved Hide resolved
@Defferrard Defferrard force-pushed the 515-failure-message-when-item-login-schema-exists branch from e7a4bd4 to fc18d30 Compare August 29, 2024 14:52
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@Defferrard Defferrard requested a review from ReidyT August 29, 2024 14:54
@Defferrard Defferrard added this pull request to the merge queue Sep 11, 2024
Merged via the queue into main with commit 31154a7 Sep 11, 2024
3 checks passed
@graasper graasper mentioned this pull request Sep 11, 2024
Merged
@spaenleh spaenleh deleted the 515-failure-message-when-item-login-schema-exists branch October 2, 2024 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ReidyT ReidyT ReidyT approved these changes

@spaenleh spaenleh spaenleh approved these changes

@pyphilia pyphilia Awaiting requested review from pyphilia

Assignees

@Defferrard Defferrard

Labels
v1.36.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

failure message when item login schema exists
3 participants
@Defferrard @spaenleh @ReidyT