Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update messages for email update #452

Merged
merged 2 commits into from
Jul 3, 2024
Merged

fix: update messages for email update #452

merged 2 commits into from
Jul 3, 2024

Conversation

spaenleh
Copy link
Member

No description provided.

@spaenleh spaenleh requested a review from pyphilia June 28, 2024 15:55
@spaenleh spaenleh self-assigned this Jun 28, 2024
@spaenleh spaenleh force-pushed the add-messages-email-change branch from ebf60d7 to 59bcd77 Compare June 28, 2024 16:01
pyphilia
pyphilia approved these changes Jul 3, 2024
View reviewed changes
Copy link
Contributor

@pyphilia pyphilia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I've suggested some changes, maybe it's clearer with them.

src/langs/en/messages.json Outdated Show resolved Hide resolved
src/langs/en/messages.json Outdated Show resolved Hide resolved
@spaenleh @pyphilia
fix: apply translation sugggestions
a8e1017 
Co-authored-by: Kim Lan Phan Hoang <[email protected]>
@spaenleh spaenleh enabled auto-merge July 3, 2024 13:56
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jul 3, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@spaenleh spaenleh added this pull request to the merge queue Jul 3, 2024
Merged via the queue into main with commit f7bf428 Jul 3, 2024
3 checks passed
@graasper graasper mentioned this pull request Jul 3, 2024
Merged
@spaenleh spaenleh deleted the add-messages-email-change branch August 22, 2024 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pyphilia pyphilia pyphilia approved these changes

Assignees

@spaenleh spaenleh

Labels
v1.31.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@spaenleh @pyphilia