Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(build): create a commonJs bundle #427

Merged
merged 8 commits into from
Jun 21, 2024
Merged

fix(build): create a commonJs bundle #427

merged 8 commits into from
Jun 21, 2024

Conversation

spaenleh
Copy link
Member

No description provided.

@spaenleh spaenleh force-pushed the remove-json-assertion branch from 8497f21 to e4b6a54 Compare June 20, 2024 12:20
@spaenleh spaenleh changed the title Create a commonJs bundle build: create a commonJs bundle Jun 20, 2024
@spaenleh spaenleh requested review from pyphilia and Defferrard June 20, 2024 16:27
@spaenleh spaenleh self-assigned this Jun 20, 2024
@spaenleh spaenleh added build Build and developer operations chore Generic task or chore labels Jun 20, 2024
Defferrard
Defferrard approved these changes Jun 21, 2024
View reviewed changes
Copy link
Contributor

@Defferrard Defferrard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

pyphilia
pyphilia approved these changes Jun 21, 2024
View reviewed changes
Copy link
Contributor

@pyphilia pyphilia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, I wonder if you really wanted to include some of the packages. Also I didn't know you can use comments in json?

package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
tsconfig.cjs.json Show resolved Hide resolved
tsconfig.esm.json Show resolved Hide resolved
tsconfig.json Show resolved Hide resolved
tsconfig.json Show resolved Hide resolved
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@spaenleh spaenleh changed the title build: create a commonJs bundle fix(build): create a commonJs bundle Jun 21, 2024
@spaenleh spaenleh added this pull request to the merge queue Jun 21, 2024
Merged via the queue into main with commit 4056d62 Jun 21, 2024
3 checks passed
@github-actions github-actions bot mentioned this pull request Jun 21, 2024
Merged
@spaenleh spaenleh deleted the remove-json-assertion branch June 26, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Defferrard Defferrard Defferrard approved these changes

@pyphilia pyphilia pyphilia approved these changes

Assignees

@spaenleh spaenleh

Labels
build Build and developer operations chore Generic task or chore v1.28.2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@spaenleh @pyphilia @Defferrard