Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add max width translations #236

Merged
merged 3 commits into from
Aug 28, 2023
Merged

feat: add max width translations #236

merged 3 commits into from
Aug 28, 2023

Conversation

pyphilia
Copy link
Contributor

No description provided.

@pyphilia pyphilia changed the title Max width translations feat: add max width translations Aug 23, 2023
@pyphilia pyphilia requested a review from spaenleh August 23, 2023 13:20
Copy link
Member

@spaenleh spaenleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the xl supposed to be maximum width ?

src/langs/fr/maxWidth.json Outdated Show resolved Hide resolved
Co-authored-by: Basile Spaenlehauer <[email protected]>
@pyphilia
Copy link
Contributor Author

@spaenleh Yes!

@spaenleh
Copy link
Member

okay, well in the docs it is set as 1536px bit I will take it 😄

@pyphilia pyphilia merged commit 6289c3f into main Aug 28, 2023
spaenleh added a commit that referenced this pull request Aug 28, 2023
* feat: add max width translations

Co-authored-by: Basile Spaenlehauer <[email protected]>

---------

Co-authored-by: Basile Spaenlehauer <[email protected]>
@spaenleh spaenleh deleted the max-width-translations branch December 4, 2023 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants