Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

138 cc translation #141

Merged
merged 21 commits into from
May 1, 2023
Merged

138 cc translation #141

merged 21 commits into from
May 1, 2023

Conversation

clementcharmillot
Copy link
Contributor

@clementcharmillot clementcharmillot commented Mar 23, 2023

Adds CC translation for the builder.

Related to:

closes #138

Copy link
Member

@spaenleh spaenleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚡ Please have a look at my comments, happy to discuss.

src/langs/en/library.json Outdated Show resolved Hide resolved
src/langs/en/library.json Outdated Show resolved Hide resolved
src/langs/fr/library.json Outdated Show resolved Hide resolved
src/langs/fr/library.json Outdated Show resolved Hide resolved
src/langs/fr/library.json Outdated Show resolved Hide resolved
Copy link
Contributor

@codeofmochi codeofmochi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✔️ consider @spaenleh 's comments, otherwise we can just merge 👍

@clementcharmillot clementcharmillot marked this pull request as ready for review April 30, 2023 20:02
Copy link
Member

@spaenleh spaenleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! 🚀

@spaenleh spaenleh merged commit f38966c into main May 1, 2023
@spaenleh spaenleh deleted the 138-cc-translation branch May 31, 2023 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add CC Rework translation
3 participants