Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add sign up enable save actions translation #129

Merged
merged 5 commits into from
Mar 17, 2023
Merged

feat: add sign up enable save actions translation #129

merged 5 commits into from
Mar 17, 2023

Conversation

rayacers
Copy link
Contributor

No description provided.

@rayacers rayacers requested a review from pyphilia March 16, 2023 13:41
@rayacers rayacers linked an issue Mar 16, 2023 that may be closed by this pull request
Add signup enable analytics translation #128
Closed
@rayacers rayacers self-assigned this Mar 16, 2023
spaenleh
spaenleh approved these changes Mar 17, 2023
View reviewed changes
Copy link
Member

@spaenleh spaenleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎈 LGTM ! We might want to check the text, or add an explanation, to let users know what we would be collecting etc ...

@rayacers
Copy link
Contributor Author

rayacers commented Mar 17, 2023 •
edited
Loading

🎈 LGTM ! We might want to check the text, or add an explanation, to let users know what we would be collecting etc ...

Yes, will do it in a follow up pr.

@rayacers rayacers merged commit c18a9a6 into main Mar 17, 2023
@github-actions github-actions bot mentioned this pull request Mar 17, 2023
Merged
@spaenleh spaenleh deleted the 128-add-signup-enable-analytics-translation branch May 31, 2023 10:58
@github-actions github-actions bot mentioned this pull request Nov 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spaenleh spaenleh spaenleh approved these changes

@pyphilia pyphilia Awaiting requested review from pyphilia

@codeofmochi codeofmochi Awaiting requested review from codeofmochi

Assignees

@rayacers rayacers

Labels
v1.9.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add signup enable analytics translation
2 participants
@rayacers @spaenleh