Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add player translations #112

Merged
merged 2 commits into from
Feb 24, 2023
Merged

feat: add player translations #112

merged 2 commits into from
Feb 24, 2023

Conversation

spaenleh
Copy link
Member

closes #101

@spaenleh spaenleh linked an issue Feb 24, 2023 that may be closed by this pull request
Add player translations #101
Closed
@spaenleh spaenleh marked this pull request as draft February 24, 2023 12:35
@spaenleh spaenleh self-assigned this Feb 24, 2023
@spaenleh spaenleh added the feature New feature or request label Feb 24, 2023
@spaenleh spaenleh marked this pull request as ready for review February 24, 2023 12:49
pyphilia
pyphilia approved these changes Feb 24, 2023
View reviewed changes
Copy link
Contributor

@pyphilia pyphilia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks for the PR!

src/langs/en/common.json Outdated Show resolved Hide resolved
src/langs/fr/player.json Outdated Show resolved Hide resolved
codeofmochi
codeofmochi approved these changes Feb 24, 2023
View reviewed changes
Copy link
Contributor

@codeofmochi codeofmochi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🥐 nice! Thank you for setting up i18n on Player 💪

@spaenleh spaenleh merged commit 5a369e9 into main Feb 24, 2023
@spaenleh spaenleh deleted the 101-add-player-translations branch February 24, 2023 16:42
@github-actions github-actions bot mentioned this pull request Feb 24, 2023
Merged
@spaenleh spaenleh mentioned this pull request Mar 2, 2023
Closed
@github-actions github-actions bot mentioned this pull request Nov 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codeofmochi codeofmochi codeofmochi approved these changes

@pyphilia pyphilia pyphilia approved these changes

@swouf swouf Awaiting requested review from swouf

Assignees

@spaenleh spaenleh

Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add player translations
3 participants
@spaenleh @pyphilia @codeofmochi