From fc1536b638c69ecd219445a9ba5822610c608d19 Mon Sep 17 00:00:00 2001
From: spaenleh <spaenleh@gmail.com>
Date: Mon, 19 Aug 2024 12:00:30 +0200
Subject: [PATCH] fix: remove extra.app.settings key in item

---
 src/item/appItem/appItem.factory.test.ts | 1 -
 src/item/appItem/appItem.factory.ts      | 1 -
 src/item/appItem/appItem.ts              | 9 +++------
 3 files changed, 3 insertions(+), 8 deletions(-)

diff --git a/src/item/appItem/appItem.factory.test.ts b/src/item/appItem/appItem.factory.test.ts
index a64eb197..b8c440fb 100644
--- a/src/item/appItem/appItem.factory.test.ts
+++ b/src/item/appItem/appItem.factory.test.ts
@@ -12,7 +12,6 @@ describe('AppItemFactory', () => {
   it('Create app item', () => {
     const item = AppItemFactory();
     expect(item.extra.app.url).toContain('http');
-    expect(item.extra.app.settings).toBeDefined();
     expect(item.type).toEqual(ItemType.APP);
   });
   it('Create app item with args', () => {
diff --git a/src/item/appItem/appItem.factory.ts b/src/item/appItem/appItem.factory.ts
index c26f1b18..02c494ce 100644
--- a/src/item/appItem/appItem.factory.ts
+++ b/src/item/appItem/appItem.factory.ts
@@ -19,7 +19,6 @@ export const AppItemFactory = (
     extra: item.extra ?? {
       [ItemType.APP]: {
         url: faker.internet.url(),
-        settings: {},
       },
     },
   };
diff --git a/src/item/appItem/appItem.ts b/src/item/appItem/appItem.ts
index ad6b9ca4..c553c670 100644
--- a/src/item/appItem/appItem.ts
+++ b/src/item/appItem/appItem.ts
@@ -12,12 +12,10 @@ export type AppItemType<S = ItemSettings> = {
  */
 export type AppItemExtraProperties = {
   url: string;
-  // todo: there currently is nothing stored in the settings. this might change later
-  settings?: unknown;
 };
-export interface AppItemExtra {
+export type AppItemExtra = {
   [ItemType.APP]: AppItemExtraProperties;
-}
+};
 
 export const getAppExtra = <U extends AppItemExtra>(
   extra: U,
@@ -25,9 +23,8 @@ export const getAppExtra = <U extends AppItemExtra>(
 
 export const buildAppExtra = ({
   url,
-  settings = {},
 }: AppItemExtraProperties): AppItemExtra => ({
-  [ItemType.APP]: { url, settings },
+  [ItemType.APP]: { url },
 });
 
 /**