feat: add building utilities for extra #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codeofmochi
reviewed
Mar 3, 2023
spaenleh
force-pushed
the
92-add-build-utilities-for-extra
branch
from
0548ca8 to
0c1a7ee
Compare
codeofmochi
reviewed
Mar 8, 2023
codeofmochi
requested changes
Mar 8, 2023
Co-authored-by: Alexandre Chau <[email protected]>
Co-authored-by: Alexandre Chau <[email protected]>
|
@dialexo Thank you for the suggestions, I added both as they make sense. |
codeofmochi
approved these changes
Mar 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds building methods to create item extras.
Will be useful to remove some duplicated utils from builder and player.
closes #92