fix: strong password type

[spaenleh]

In this PR I fix a type issue with the recently refactored isStrongPassword function.

This function as ported from the validator.js package was accepting an options parameter that could contain the returnScore option. If this was present it would return the score of the password. So the signature of the function was number | boolean. I think this does not makes sens with the name of the function is* where we expect it to return boolean exclusively. So I split the functionality in two functions: isStrongPassword and getPasswordScore that have their own purpose.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[ReidyT]

Really good refactor 🤖! I'm wondering if the getPasswordScore is really useful for us. If it's not the case, maybe we should consider to remove it?

[spaenleh]

Thank you for your review @ReidyT.

I think currently we are not using it, but it could be used where the user chooses a password to give them a visual indication of the strength of their password. So I think we could keep it for now and see later if we can use it. How does it sound ?