Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add email validation #689

Merged
merged 2 commits into from
Nov 11, 2024
Merged

feat: add email validation #689

merged 2 commits into from
Nov 11, 2024

Conversation

spaenleh
Copy link
Member

@spaenleh spaenleh commented Nov 4, 2024

This PR adds the code necessary to perform email validation without the need for an external library. The code is heavily based on the npm package validator.js

Copy link

gitguardian bot commented Nov 4, 2024

️✅ There are no secrets present in this pull request anymore.

If these secrets were true positive and are still valid, we highly recommend you to revoke them.
Once a secret has been leaked into a git repository, you should consider it compromised, even if it was deleted immediately.
Find here more information about risks.


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@spaenleh spaenleh self-assigned this Nov 4, 2024
@spaenleh spaenleh requested review from pyphilia and ReidyT November 4, 2024 14:27
@spaenleh spaenleh added the feature New feature or request label Nov 4, 2024
Copy link
Contributor

@pyphilia pyphilia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, I have the same comment : add the source of the code.

src/index.ts Show resolved Hide resolved
@spaenleh spaenleh force-pushed the add-is-email-validation branch from 6c76b67 to 8280f94 Compare November 4, 2024 15:02
Copy link
Contributor

@ReidyT ReidyT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🌨️

@spaenleh spaenleh force-pushed the add-is-email-validation branch from 8280f94 to 212dfda Compare November 11, 2024 08:07
Copy link

@spaenleh spaenleh added this pull request to the merge queue Nov 11, 2024
Merged via the queue into main with commit 7433e84 Nov 11, 2024
3 checks passed
@spaenleh spaenleh deleted the add-is-email-validation branch November 21, 2024 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request v5.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants