Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add get link thumbnail function #582

Merged
merged 4 commits into from
Jul 18, 2024
Merged

feat: add get link thumbnail function #582

merged 4 commits into from
Jul 18, 2024

Conversation

pyphilia
Copy link
Contributor

No description provided.

@pyphilia pyphilia requested review from spaenleh and ReidyT July 15, 2024 13:28
@pyphilia pyphilia self-assigned this Jul 15, 2024
spaenleh
spaenleh reviewed Jul 15, 2024
View reviewed changes
Copy link
Member

@spaenleh spaenleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is noce to add this utility function.
See my comment and rational. Let me know what you think.

src/item/linkItem/linkItem.test.ts Outdated Show resolved Hide resolved
@pyphilia pyphilia requested a review from spaenleh July 18, 2024 09:27
spaenleh
spaenleh approved these changes Jul 18, 2024
View reviewed changes
Copy link
Member

@spaenleh spaenleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the change about the size I really like it.

Is it important to return null ? I have suggested some changes to simplify the handling since getting the first element of the array already returns undefined if the array is empty.

src/item/linkItem/linkItem.test.ts Outdated Show resolved Hide resolved
src/item/linkItem/linkItem.ts Outdated Show resolved Hide resolved
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@pyphilia pyphilia enabled auto-merge July 18, 2024 12:00
@pyphilia pyphilia added this pull request to the merge queue Jul 18, 2024
Merged via the queue into main with commit 7ec207f Jul 18, 2024
3 checks passed
@graasper graasper mentioned this pull request Jul 18, 2024
Merged
@pyphilia pyphilia deleted the link-thumbnail branch August 5, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spaenleh spaenleh spaenleh approved these changes

@ReidyT ReidyT Awaiting requested review from ReidyT

Assignees

@pyphilia pyphilia

Labels
v4.18.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pyphilia @spaenleh @ReidyT