Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: increase copy limit to 400 #536

Merged
merged 1 commit into from
May 29, 2024
Merged

fix: increase copy limit to 400 #536

merged 1 commit into from
May 29, 2024

Conversation

spaenleh
Copy link
Member

@spaenleh spaenleh commented May 29, 2024 •
edited
Loading

Should we also increase the delete limit to allow deleting content that was copied ?
fix #535

@spaenleh spaenleh self-assigned this May 29, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

pyphilia
pyphilia approved these changes May 29, 2024
View reviewed changes
Copy link
Contributor

@pyphilia pyphilia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete will trigger cascade, and those we cannot remove. Would be wiser to make tests first.

@spaenleh spaenleh added this pull request to the merge queue May 29, 2024
Merged via the queue into main with commit f2d14e9 May 29, 2024
3 checks passed
@github-actions github-actions bot mentioned this pull request May 29, 2024
Merged
@spaenleh spaenleh deleted the 535-increase-copy-limit branch June 26, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pyphilia pyphilia pyphilia approved these changes

@Defferrard Defferrard Awaiting requested review from Defferrard

@ReidyT ReidyT Awaiting requested review from ReidyT

Assignees

@spaenleh spaenleh

Labels
improvement v4.12.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Increase copy limit
2 participants
@spaenleh @pyphilia