Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove UnknownExtra #298

Merged
merged 2 commits into from
Oct 24, 2023
Merged

fix: remove UnknownExtra #298

merged 2 commits into from
Oct 24, 2023

Conversation

spaenleh
Copy link
Member

@spaenleh spaenleh commented Oct 23, 2023 •
edited
Loading

In this PR I remove the UnknownExtra to enforce stronger types and remove errors with types generalizing to [x: string]: unknown in TS.

@spaenleh spaenleh requested a review from pyphilia October 23, 2023 13:20
@spaenleh spaenleh self-assigned this Oct 23, 2023
@spaenleh spaenleh added chore Generic task or chore improvement labels Oct 23, 2023
pyphilia
pyphilia approved these changes Oct 23, 2023
View reviewed changes
Copy link
Contributor

@pyphilia pyphilia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🍟

tsconfig.json Show resolved Hide resolved
@spaenleh spaenleh merged commit 858680b into main Oct 24, 2023
2 checks passed
@github-actions github-actions bot mentioned this pull request Oct 24, 2023
Merged
@spaenleh spaenleh deleted the remove-unknown-extra branch November 3, 2023 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pyphilia pyphilia pyphilia approved these changes

Assignees

@spaenleh spaenleh

Labels
chore Generic task or chore improvement v1.9.2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@spaenleh @pyphilia