Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(type): item.description to be nullable #207

Merged
merged 1 commit into from
Jul 12, 2023
Merged

fix(type): item.description to be nullable #207

merged 1 commit into from
Jul 12, 2023

Conversation

spaenleh
Copy link
Member

This PR updates the type of Item to reflect the nullable property of description.

This is correct with the item schema defined in the backend.

@spaenleh spaenleh linked an issue Jul 10, 2023 that may be closed by this pull request
Fix Item description type to include null #206
Closed
@spaenleh spaenleh requested a review from morganridel July 10, 2023 12:40
@spaenleh spaenleh self-assigned this Jul 10, 2023
@spaenleh spaenleh added the chore Generic task or chore label Jul 10, 2023
@spaenleh spaenleh merged commit e8e7148 into main Jul 12, 2023
@github-actions github-actions bot mentioned this pull request Jul 12, 2023
Merged
@spaenleh spaenleh deleted the 206-fix-item-description-type-to-include-null branch September 19, 2023 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@morganridel morganridel morganridel approved these changes

Assignees

@spaenleh spaenleh

Labels
chore Generic task or chore v1.1.2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix Item description type to include null
2 participants
@spaenleh @morganridel