Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecations are not visible in clients #926

Open
spaenleh opened this issue Sep 20, 2024 · 0 comments
Open

Deprecations are not visible in clients #926

spaenleh opened this issue Sep 20, 2024 · 0 comments
Labels
question Further information is requested

Comments

@spaenleh
Copy link
Member

Issue

When marking a hook as deprecated in query-client it does not show in the client code.
This is due to two things:

  • we do not keep the comments
  • we spread the return from the hooks, so we loose the deprecation

Solution

If we can remove the need for the configureHooks this issue can be resolved.
For this we need to remove the need for the API_HOST env variable.
This can be done by calling the api on the same host, by removing the crossOrigin issue.
If we remove the crossOrigin calls we can also remove the usage of the withCredentials that is added in the configureAxios function.

In summary if we move to a single origin architecture with the api running on the /api subpath and apps running on their own paths (/builder etc).

To solve the issue of the local development we could use the proxy feature from the vite development server which would allow to have requests to /api go to http://localhost:3000 instead of http://localhost:3111/api (for builder for example).

@spaenleh spaenleh added the question Further information is requested label Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant