Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add geolocation address and parent item #630

Merged
merged 2 commits into from
Feb 14, 2024
Merged

Conversation

pyphilia
Copy link
Contributor

@pyphilia pyphilia commented Feb 12, 2024

  • allow returning null geolocation
  • new hook: useAddressFromCoordinates
  • add parentItemId for search hook
  • add addressLabel on put

@pyphilia pyphilia self-assigned this Feb 12, 2024
@pyphilia pyphilia changed the title Geolocation address feat: add geolocation address and parent item Feb 12, 2024
@pyphilia pyphilia requested review from spaenleh and ReidyT February 14, 2024 09:22
@pyphilia pyphilia force-pushed the geolocation-address branch from d3bdf98 to 660f244 Compare February 14, 2024 10:32
Copy link
Member

@spaenleh spaenleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just some comments.

src/api/itemGeolocation.ts Outdated Show resolved Hide resolved
src/hooks/itemGeolocation.test.ts Outdated Show resolved Hide resolved
src/mutations/itemGeolocation.test.ts Outdated Show resolved Hide resolved
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
7.3% Duplication on New Code

See analysis details on SonarCloud

@pyphilia pyphilia merged commit d620371 into main Feb 14, 2024
3 checks passed
@pyphilia pyphilia deleted the geolocation-address branch February 14, 2024 12:47
This was referenced Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants