feat: add geolocation hooks and mutations #590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pyphilia
force-pushed
the
588-geolocation
branch
from
2da8dc4 to
0fc1baa
Compare
spaenleh
requested changes
Jan 29, 2024
Comment on lines
+47
to
+52
| const enabled = Boolean( | ||
| (lat1 || lat1 === 0) && | ||
| (lat2 || lat2 === 0) && | ||
| (lng1 || lng1 === 0) && | ||
| (lng2 || lng2 === 0), | ||
| ); |
There was a problem hiding this comment.
Reading the type here it looks like this condition can never be false ?
There was a problem hiding this comment.
It is false if one of the prop is null, or am I wrong?
On the contrary all values should be set (set at 0 is valid) to be true.
There was a problem hiding this comment.
ItemGelolocation['lat'] is a number so they can not be null ?
There was a problem hiding this comment.
right but we never know aha
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #588