Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add short links feature (graasp/graasp#664) #516

Merged
merged 9 commits into from
Nov 28, 2023

Conversation

ReidyT
Copy link
Contributor

@ReidyT ReidyT commented Nov 10, 2023

Add short links hooks and mutations to allow the builder to communicate with the backend's routes.

@ReidyT ReidyT added the feature New feature or request label Nov 10, 2023
@ReidyT ReidyT self-assigned this Nov 10, 2023
@ReidyT ReidyT requested review from spaenleh and pyphilia November 10, 2023 09:11
@ReidyT ReidyT force-pushed the 664-add-short-links-feature branch from 96758aa to ff32379 Compare November 10, 2023 09:43
Copy link
Member

@spaenleh spaenleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice ! Just some comments and file organisation

src/mutations/item.ts Outdated Show resolved Hide resolved
src/hooks/item.ts Outdated Show resolved Hide resolved
src/config/keys.ts Outdated Show resolved Hide resolved
src/config/keys.ts Outdated Show resolved Hide resolved
@ReidyT ReidyT requested a review from spaenleh November 10, 2023 14:46
Copy link
Member

@spaenleh spaenleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks much better ! Just a nitpick on naming conventions.

src/mutations/index.ts Outdated Show resolved Hide resolved
- This commit not compile due to latest SDK version
- It would be interesting to update the code to remove the immutable types

feat(chore): remove unused useShortLink hook (#664)

feat: update short links PATCH methods to use AnyOfExcept type
- Before this modification, the type used for the payload of patch was Partial
- Short link hooks allow to check if a short link already exist
- Messages key allow to translate short link success and errors

fix: prettify keys.ts file
@ReidyT ReidyT force-pushed the 664-add-short-links-feature branch from dfcabed to b854259 Compare November 28, 2023 14:14
@ReidyT ReidyT merged commit f6d724a into main Nov 28, 2023
2 checks passed
@ReidyT ReidyT deleted the 664-add-short-links-feature branch November 28, 2023 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request v2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants