generated from graasp/graasp-repo
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add short links feature (graasp/graasp#664) #516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ReidyT
force-pushed
the
664-add-short-links-feature
branch
from
November 10, 2023 09:43
96758aa
to
ff32379
Compare
spaenleh
requested changes
Nov 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice ! Just some comments and file organisation
spaenleh
approved these changes
Nov 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks much better ! Just a nitpick on naming conventions.
- This commit not compile due to latest SDK version - It would be interesting to update the code to remove the immutable types feat(chore): remove unused useShortLink hook (#664) feat: update short links PATCH methods to use AnyOfExcept type - Before this modification, the type used for the payload of patch was Partial
- Short link hooks allow to check if a short link already exist - Messages key allow to translate short link success and errors fix: prettify keys.ts file
ReidyT
force-pushed
the
664-add-short-links-feature
branch
from
November 28, 2023 14:14
dfcabed
to
b854259
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add short links hooks and mutations to allow the builder to communicate with the backend's routes.