fix(type): use correct type for transformed date #470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morganridel
approved these changes
Oct 11, 2023
ReidyT
approved these changes
Oct 11, 2023
spaenleh
force-pushed
the
469-fix-type-of-data-returned-by-useaggregateactions-1
branch
from
f1ced88 to
02a126e
Compare
ReidyT
reviewed
Nov 2, 2023
ReidyT
approved these changes
Nov 2, 2023
spaenleh
force-pushed
the
469-fix-type-of-data-returned-by-useaggregateactions-1
branch
from
6287ed9 to
8b88751
Compare
spaenleh
deleted the
469-fix-type-of-data-returned-by-useaggregateactions-1
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes incorrect types in the hooks.
Explanation
The API returns the
createdAtDayas a ISOString representation of a date.We have an interceptor for axios that automatically applies a transform to convert dates formatted in strings to
Dateobjects. So the correct type that the consumer will see in this case isDate.