fix: webpack import error #441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spaenleh
added
bug 🪲
pyphilia
approved these changes
Sep 25, 2023
src/hooks/mention.test.ts
Outdated
| @@ -45,6 +45,7 @@ describe('Chat Mention Hooks', () => { | |||
| hook, | |||
| wrapper, | |||
| }); | |||
| console.log(data?.toJS(), response.toJS()); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Origin of the error
In #430 we specified the package as using ESM (with
type: modulein package.json).Cypress uses webpack to transpile the test code and when using the query-client package it was looking for fully specified imports (needs the .js extension) as this is in the specs of ESM. But our code was not fully specifying the imports.
Fix:
To fix this issue we:
type: "commonjs"in package.jsontsccommonjsintsconfig.jsonAdditional changes
We also fixed the following:
@testing-library/react-hooks