Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add mock websockets client #321

Merged
merged 2 commits into from
Jun 29, 2023
Merged

fix: add mock websockets client #321

merged 2 commits into from
Jun 29, 2023

Conversation

spaenleh
Copy link
Member

No description provided.

@spaenleh spaenleh linked an issue Jun 29, 2023 that may be closed by this pull request
Migrate mock WebSocket client from plugin-websockets #320
Closed
@spaenleh spaenleh requested a review from codeofmochi June 29, 2023 09:11
@spaenleh spaenleh self-assigned this Jun 29, 2023
@spaenleh spaenleh added chore Generic task or chore test labels Jun 29, 2023
codeofmochi
codeofmochi requested changes Jun 29, 2023
View reviewed changes
Copy link
Contributor

@codeofmochi codeofmochi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we not include it into export indices?

src/index.ts Show resolved Hide resolved
src/ws/index.ts Show resolved Hide resolved
@spaenleh spaenleh force-pushed the 320-migrate-mock-websocket-client-from-plugin-websockets branch from f4d824b to 540ce74 Compare June 29, 2023 12:52
@spaenleh spaenleh requested a review from codeofmochi June 29, 2023 14:07
@spaenleh
Copy link
Member Author

As discussed with you @dialexo removing the mockweboscket from the index so they are not included in the bundle was not easy to do.
I tried to convert the package to pure TS (no bundling) but in that case we had issues with webpack compiling the tests in cypress...

So for the moment i think it is ok to have it in the bundle even if it is not nice to put test code in production bundles.

codeofmochi
codeofmochi approved these changes Jun 29, 2023
View reviewed changes
Copy link
Contributor

@codeofmochi codeofmochi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with the aforementioned caveat 🗻

jest.config.ts Show resolved Hide resolved
@spaenleh spaenleh merged commit b8734b8 into main Jun 29, 2023
@spaenleh spaenleh deleted the 320-migrate-mock-websocket-client-from-plugin-websockets branch June 29, 2023 14:47
@github-actions github-actions bot mentioned this pull request Jun 29, 2023
Merged
@github-actions github-actions bot mentioned this pull request Feb 8, 2024
Closed
@github-actions github-actions bot mentioned this pull request Feb 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codeofmochi codeofmochi codeofmochi approved these changes

Assignees

@spaenleh spaenleh

Labels
chore Generic task or chore test v1.1.3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate mock WebSocket client from plugin-websockets
2 participants
@spaenleh @codeofmochi