Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: handle favorite queries #275

Merged
merged 5 commits into from
Jun 20, 2023
Merged

feat: handle favorite queries #275

merged 5 commits into from
Jun 20, 2023

Conversation

morganridel
Copy link
Contributor

@morganridel morganridel commented May 23, 2023 •
edited
Loading

This was referenced May 23, 2023
Merged
Merged
@morganridel morganridel force-pushed the refactor-favorite branch 2 times, most recently from f3c95b7 to 4e48105 Compare June 1, 2023 08:46
@spaenleh spaenleh changed the base branch from typeorm to main June 14, 2023 09:27
spaenleh
spaenleh requested changes Jun 14, 2023
View reviewed changes
Copy link
Member

@spaenleh spaenleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌳 Looks good, just a few comments, really like the simplicity of this since it has been de-coupled 👍

src/api/itemFavorite.ts Outdated Show resolved Hide resolved
src/hooks/itemFavorite.test.ts Outdated Show resolved Hide resolved
src/hooks/itemFavorite.test.ts Outdated Show resolved Hide resolved
src/mutations/itemFavorite.test.ts Outdated Show resolved Hide resolved
src/mutations/itemFavorite.test.ts Outdated Show resolved Hide resolved
src/mutations/itemFavorite.ts Outdated Show resolved Hide resolved
test/constants.ts
export const FAVORITE_ITEM: ItemFavoriteRecord = convertJs([
{
id: `favorite-item-id`,
item: ITEM_1,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing createdAt

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's just not useful in these tests so I didn't put a value

@morganridel morganridel requested review from spaenleh and pyphilia June 20, 2023 07:39
pyphilia
pyphilia approved these changes Jun 20, 2023
View reviewed changes
Copy link
Contributor

@pyphilia pyphilia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM I've left one comment so we can move forward to a new format for mutations.

src/mutations/itemFavorite.ts Outdated Show resolved Hide resolved
@morganridel morganridel requested a review from pyphilia June 20, 2023 13:46
@morganridel morganridel merged commit ac63c4b into main Jun 20, 2023
@github-actions github-actions bot mentioned this pull request Jun 20, 2023
Merged
@spaenleh spaenleh deleted the refactor-favorite branch July 12, 2023 19:47
@github-actions github-actions bot mentioned this pull request Feb 8, 2024
Closed
@github-actions github-actions bot mentioned this pull request Feb 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spaenleh spaenleh spaenleh approved these changes

@pyphilia pyphilia Awaiting requested review from pyphilia

Assignees
No one assigned
Labels
v1.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@morganridel @pyphilia @spaenleh