Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: deduplicate item ids on add favorites #256

Merged
merged 1 commit into from
Mar 16, 2023

Conversation

spaenleh
Copy link
Member

This PR makes sure that when adding a favorite item it is not possible to save duplicate items.

closes #204

@spaenleh spaenleh added the bug 🪲 Something isn't working label Mar 14, 2023
@spaenleh spaenleh self-assigned this Mar 14, 2023
@spaenleh spaenleh linked an issue Mar 14, 2023 that may be closed by this pull request
Copy link
Contributor

@codeofmochi codeofmochi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's fine, but what do you think about the alternatives?

src/mutations/member.ts Outdated Show resolved Hide resolved
src/mutations/member.ts Outdated Show resolved Hide resolved
@spaenleh spaenleh force-pushed the 204-prevent-duplicate-favorite-items branch from 5ea217e to 38d0e7a Compare March 16, 2023 09:54
@spaenleh spaenleh merged commit 3b40b5d into main Mar 16, 2023
@spaenleh spaenleh deleted the 204-prevent-duplicate-favorite-items branch March 16, 2023 12:24
@spaenleh spaenleh restored the 204-prevent-duplicate-favorite-items branch March 16, 2023 12:37
@spaenleh spaenleh deleted the 204-prevent-duplicate-favorite-items branch March 17, 2023 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🪲 Something isn't working v0.3.3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prevent duplicate favorite items
2 participants