Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use ThumbnailSize from sdk #252

Merged
merged 2 commits into from
Mar 9, 2023
Merged

fix: use ThumbnailSize from sdk #252

merged 2 commits into from
Mar 9, 2023

Conversation

spaenleh
Copy link
Member

@spaenleh spaenleh commented Mar 8, 2023

This PR uses ThumbnailSizes defined in sdk instead of own constant

closes #251

@spaenleh spaenleh linked an issue Mar 8, 2023 that may be closed by this pull request
Use ThumbnailSize from sdk #251
Closed
@spaenleh spaenleh added bug 🪲 Something isn't working improvement Not a feature but a QoL improvement in DX labels Mar 8, 2023
@spaenleh spaenleh self-assigned this Mar 8, 2023
@spaenleh spaenleh requested review from codeofmochi and pyphilia March 8, 2023 15:08
pyphilia
pyphilia approved these changes Mar 9, 2023
View reviewed changes
Copy link
Contributor

@pyphilia pyphilia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Niiice 🌴

src/config/constants.ts Outdated Show resolved Hide resolved
codeofmochi
codeofmochi reviewed Mar 9, 2023
View reviewed changes
Copy link
Contributor

@codeofmochi codeofmochi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I have a question regarding tsconfig 🤔

package.json Show resolved Hide resolved
src/config/constants.ts Outdated Show resolved Hide resolved
tsconfig.test.json Show resolved Hide resolved
@spaenleh spaenleh merged commit 58941fe into main Mar 9, 2023
@spaenleh spaenleh deleted the 251-use-thumbnailsize-from-sdk branch March 9, 2023 14:17
@github-actions github-actions bot mentioned this pull request Mar 9, 2023
Merged
@github-actions github-actions bot mentioned this pull request Feb 8, 2024
Closed
@github-actions github-actions bot mentioned this pull request Feb 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codeofmochi codeofmochi codeofmochi left review comments

@pyphilia pyphilia pyphilia approved these changes

Assignees

@spaenleh spaenleh

Labels
bug 🪲 Something isn't working improvement Not a feature but a QoL improvement in DX v0.3.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use ThumbnailSize from sdk
3 participants
@spaenleh @pyphilia @codeofmochi