Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: show skeleton on loading on home page #694

Merged
merged 2 commits into from
Sep 25, 2024
Merged

Conversation

pyphilia
Copy link
Contributor

The result could be better, but we will change cards anyway, so let's have this first simple skeleton.

Screenshot 2024-09-24 at 17 33 54

close #688

@pyphilia pyphilia requested a review from ReidyT September 24, 2024 15:34
@pyphilia pyphilia self-assigned this Sep 24, 2024
Copy link
Contributor

@ReidyT ReidyT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I just let you a suggestion to avoid duplicating same code 🚀

src/components/collection/CollectionsGrid.tsx Outdated Show resolved Hide resolved
@pyphilia pyphilia enabled auto-merge September 25, 2024 10:57
Copy link

@pyphilia pyphilia added this pull request to the merge queue Sep 25, 2024
Merged via the queue into main with commit 87ec65a Sep 25, 2024
3 checks passed
@spaenleh spaenleh deleted the 688-home-skeleton branch October 2, 2024 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add skeletons for collections loading on the home page
2 participants