make dialogs modals #152
Closed
make dialogs modals #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
make the file and message pop ups modals (children of the main window) so that they don't open up a second app instance/dock icon (at least in Linux, haven't test Windows or MacOS), and stay on top of the main window preventing getting lost confusingly behind main window. Disables main window when dialogues are open - can't think of a time when you wouldn't want this.
bootsa
pushed a commit
to bootsa/graasp-desktop
that referenced
this pull request
Aug 28, 2019
make os dialogs (open, save, etc) modal so they appear above main window and not as a separate window. fixes graasp#152
|
Sorry, been away for a couple of weeks. Not sure if I submitted it correctly as I did it on another branch and referenced here. Does that work or do I need to create another pull request? |
|
Hi @bootsa, you've correctly fixed the conflicts, but you've overridden your changes. We can either (1) close this PR and you can do your changes in a fresh new one. Or (2) you can add your new changes to this PR. I would prefer option (1). |
Merged
|
Hi @juancarlosfarah, Oops! OK, have now created a new pull request #182 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make the file and message pop ups modals (children of the main window) so that they don't open up a second app instance/dock icon (at least in Linux, haven't test Windows or MacOS), and stay on top of the main window preventing getting lost confusingly behind main window.
Disables main window when dialogues are open - can't think of a time when you wouldn't want this.