fix: default to using https if url has no protocol

closes #161

public/app/config/config.js

@@ -44,8 +44,10 @@ const TMP_FOLDER = 'tmp';
 const DEFAULT_LANG = 'en';
 const DEFAULT_DEVELOPER_MODE = false;
 const DEFAULT_GEOLOCATION_ENABLED = false;
+const DEFAULT_PROTOCOL = 'https';
 
 module.exports = {
+  DEFAULT_PROTOCOL,
   DEFAULT_DEVELOPER_MODE,
   DEFAULT_GEOLOCATION_ENABLED,
   DOWNLOADABLE_MIME_TYPES,

public/app/download.js

@@ -1,9 +1,11 @@
+const _ = require('lodash');
 const request = require('request-promise');
 const cheerio = require('cheerio');
 const download = require('download');
 const providers = require('./config/providers');
 const logger = require('./logger');
 const mapping = require('./config/mapping');
+const { DEFAULT_PROTOCOL } = require('./config/config');
 const {
   getExtension,
   isDownloadable,
@@ -52,8 +54,8 @@ const downloadSpaceResources = async ({ lang, space, absoluteSpacePath }) => {
       const { key } = asset;
       if (url) {
         // default to https
-        if (url.startsWith('//')) {
-          url = `https:${url}`;
+        if (_.isString(url) && url.startsWith('//')) {
+          url = `${DEFAULT_PROTOCOL}:${url}`;
         }
 
         // get extension to save file

src/components/phase/PhaseItem.js

@@ -1,4 +1,5 @@
 import React from 'react';
+import _ from 'lodash';
 import PropTypes from 'prop-types';
 import {
   TEXT,
@@ -7,14 +8,16 @@ import {
   RESOURCE,
   APPLICATION,
   IFRAME,
+  DEFAULT_PROTOCOL,
 } from '../../config/constants';
 import PhaseText from './PhaseText';
 import PhaseImage from './PhaseImage';
 import PhaseVideo from './PhaseVideo';
 import PhaseApp from './PhaseApp';
 
-const renderResource = item => {
-  const { id, mimeType, content, asset, url, name } = item;
+// prop types gets confused when dealing with helper renderers
+// eslint-disable-next-line react/prop-types
+const renderResource = ({ id, mimeType, content, asset, url, name }) => {
   if (mimeType === TEXT) {
     return <PhaseText key={id} id={id} content={content} />;
   }
@@ -44,10 +47,19 @@ const renderResource = item => {
 };
 
 const PhaseItem = ({ item, spaceId, phaseId }) => {
-  const { id, category, asset, url, name, appInstance } = item;
+  const { id, category, asset, name, appInstance, mimeType, content } = item;
+
+  // we might need to fiddle with the url's protocol
+  let { url } = item;
+
+  // default to https urls for items to avoid electron using file:// by default
+  if (_.isString(url) && url.startsWith('//')) {
+    url = `${DEFAULT_PROTOCOL}:${url}`;
+  }
+
   switch (category) {
     case RESOURCE:
-      return renderResource(item);
+      return renderResource({ id, mimeType, content, asset, url, name });
 
     case APPLICATION:
       return (

src/config/constants.js

@@ -17,3 +17,4 @@ export const CONTROL_TYPES = {
   SWITCH: 'SWITCH',
 };
 export const MIN_CARD_WIDTH = 345;
+export const DEFAULT_PROTOCOL = 'https';