Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: apply small fixes #386

Merged
merged 2 commits into from
Jun 22, 2022
Merged

feat: apply small fixes #386

merged 2 commits into from
Jun 22, 2022

Conversation

pyphilia
Copy link
Contributor

This PR introduces small fixes:

rename recycle bin to trash
fix breadcrumb navigation
show shared items in tree modal
show member in shared items table
change username to pseudo
clear email input on invite
@pyphilia pyphilia requested a review from codeofmochi June 21, 2022 14:19
@pyphilia pyphilia self-assigned this Jun 21, 2022
Copy link
Contributor

@codeofmochi codeofmochi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice thanks! 🐶 I have a few nitpicks regarding style, translations, and some parts of the code I'm not sure I understand

src/components/item/sharing/CreateItemMembershipForm.js Outdated Show resolved Hide resolved
src/components/item/sharing/VisibilitySelect.js Outdated Show resolved Hide resolved
src/components/item/sharing/VisibilitySelect.js Outdated Show resolved Hide resolved
src/components/main/TreeModal.js Outdated Show resolved Hide resolved
src/components/main/TreeModal.js Outdated Show resolved Hide resolved
src/components/main/TreeModal.js Outdated Show resolved Hide resolved
src/components/main/TreeModal.js Show resolved Hide resolved
src/config/constants.js Show resolved Hide resolved
src/langs/en.json Outdated Show resolved Hide resolved
src/langs/fr.json Outdated Show resolved Hide resolved
@pyphilia pyphilia merged commit 6cfb528 into master Jun 22, 2022
@pyphilia pyphilia deleted the 385/smallFixes branch June 22, 2022 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change Username to Pseudonyme Copy and move in shared items Rename recycle to trash
2 participants