Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix mentions #71

Merged
merged 5 commits into from
Jan 25, 2023
Merged

Fix mentions #71

merged 5 commits into from
Jan 25, 2023

Conversation

spaenleh
Copy link
Member

This PR fixes issues with mention parsing.

I left #61 open since we will need to remove the legacy syntax and simplify the logic in some time.
closes #60

@spaenleh spaenleh requested a review from pyphilia January 25, 2023 11:03
@spaenleh spaenleh self-assigned this Jan 25, 2023
@spaenleh spaenleh added the bug Something isn't working label Jan 25, 2023
pyphilia
pyphilia approved these changes Jan 25, 2023
View reviewed changes
Copy link
Contributor

@pyphilia pyphilia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐟

cypress/components/mention-parsing.cy.tsx Outdated Show resolved Hide resolved
@spaenleh spaenleh merged commit 2a85484 into main Jan 25, 2023
@spaenleh spaenleh deleted the 61-fix-mentions branch January 25, 2023 13:38
@github-actions github-actions bot mentioned this pull request Jan 25, 2023
Merged
@spaenleh spaenleh added the v1.0.1 fix mentions label Jan 25, 2023
@spaenleh spaenleh mentioned this pull request Jan 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pyphilia pyphilia pyphilia approved these changes

Assignees

@spaenleh spaenleh

Labels
bug Something isn't working v1.0.1 fix mentions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix mention regex
2 participants
@spaenleh @pyphilia