Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: mentions not being sent in dev #52

Merged
merged 13 commits into from
Sep 8, 2022
Merged

fix: mentions not being sent in dev #52

merged 13 commits into from
Sep 8, 2022

Conversation

spaenleh
Copy link
Member

@spaenleh spaenleh commented Sep 5, 2022 •
edited
Loading

This PR fixes:

closes #51
closes #50

@spaenleh spaenleh self-assigned this Sep 6, 2022
@spaenleh spaenleh added the bug Something isn't working label Sep 7, 2022
pyphilia
pyphilia approved these changes Sep 8, 2022
View reviewed changes
Copy link
Contributor

@pyphilia pyphilia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added minor suggestions, nice debugging! 🦧

example/src/components/ChatboxTest.tsx Outdated Show resolved Hide resolved
example/src/components/ChatboxTest.tsx Show resolved Hide resolved
example/src/components/ChatboxWrapper.tsx Show resolved Hide resolved
example/src/components/ChatboxWrapper.tsx Outdated Show resolved Hide resolved
example/src/config/constants.js Outdated Show resolved Hide resolved
src/components/Chatbox/Input.tsx Outdated Show resolved Hide resolved
src/components/Chatbox/Input.tsx Outdated Show resolved Hide resolved
src/components/Chatbox/Input.tsx Outdated Show resolved Hide resolved
src/components/Chatbox/Input.tsx Outdated Show resolved Hide resolved
src/components/Chatbox/InputBar.tsx Outdated Show resolved Hide resolved
@spaenleh spaenleh merged commit a746be1 into main Sep 8, 2022
@spaenleh spaenleh deleted the 51/fixMentionsNotSent branch September 8, 2022 08:32
@github-actions github-actions bot mentioned this pull request Nov 3, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pyphilia pyphilia pyphilia approved these changes

@codeofmochi codeofmochi Awaiting requested review from codeofmochi

Assignees

@spaenleh spaenleh

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mentions are not sent on message post Mark mention as read when click navigates to conversation
2 participants
@spaenleh @pyphilia