Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use new graasp UI #997

Merged
merged 16 commits into from
Feb 14, 2024
Merged

feat: use new graasp UI #997

merged 16 commits into from
Feb 14, 2024

Conversation

spaenleh
Copy link
Member

@spaenleh spaenleh commented Feb 8, 2024

In this PR:

  • update to use the new UI refactor
  • allow to edit the content of a document in raw mode
  • render document content with Interweave allowing to display <table> elements
    • Caveat: the <style> tag is not supported by interweave, instead use inline styles on each element you want to style.

@spaenleh spaenleh changed the title Use new graasp UI feat: use new graasp UI Feb 9, 2024
@spaenleh spaenleh marked this pull request as ready for review February 12, 2024 08:28
@spaenleh spaenleh requested a review from pyphilia February 12, 2024 08:34
@spaenleh spaenleh self-assigned this Feb 12, 2024
@spaenleh spaenleh added improvement feature New feature or request labels Feb 12, 2024
@spaenleh spaenleh requested a review from ReidyT February 12, 2024 13:59
Copy link
Contributor

@ReidyT ReidyT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice ! LGTM 👍

cypress/e2e/item/edit/editLink.cy.ts Outdated Show resolved Hide resolved
src/components/item/form/DocumentForm.tsx Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
src/components/Root.tsx Show resolved Hide resolved
src/components/item/form/DocumentForm.tsx Show resolved Hide resolved
src/components/item/form/DocumentForm.tsx Outdated Show resolved Hide resolved
src/components/item/form/DocumentForm.tsx Show resolved Hide resolved
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@spaenleh spaenleh merged commit dfaba0a into main Feb 14, 2024
4 checks passed
@spaenleh spaenleh deleted the use-new-graasp-ui branch February 14, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request improvement v2.8.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants