feat: merge metadata and settings, add tags and geoloc #996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think I did most of the work, I still need to write tests if you want to take a look to the layout. |
ReidyT
reviewed
Feb 14, 2024
There was a problem hiding this comment.
The PR looks nice ! I just let some comments.
I just have a global comment about the UI. If I don't say a mistake, the tags input is the only one where you have to save manually. I think it could be more user friendly to auto save the changes in the tags if possible, to have the same behaviour as for the rest of the inputs.
pyphilia
force-pushed
the
995-info-settings
branch
from
21aa50f to
7c83873
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #995