Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: migrate Copy and CreateShortcut modals to ItemSelectionModal #988

Merged
merged 16 commits into from
Feb 9, 2024
Merged

feat: migrate Copy and CreateShortcut modals to ItemSelectionModal #988

merged 16 commits into from
Feb 9, 2024

Conversation

ReidyT
Copy link
Contributor

@ReidyT ReidyT commented Feb 2, 2024 •
edited
Loading

This PR includes:

  • the migration of the copy and create shortcut modals to use ItemSelectionModal
  • the children are still filtered in the frontend

@ReidyT ReidyT self-assigned this Feb 2, 2024
@ReidyT ReidyT force-pushed the 606-children-item-by-type branch 5 times, most recently from 6005f61 to 3a106eb Compare February 6, 2024 16:08
@ReidyT ReidyT changed the title feat: filter children items by types using useChildren feat: migrate Copy and CreateShortcut modals to ItemSelectionModal Feb 6, 2024
@ReidyT ReidyT requested review from pyphilia and spaenleh and removed request for pyphilia February 6, 2024 16:12
@ReidyT ReidyT marked this pull request as ready for review February 6, 2024 16:13
pyphilia
pyphilia previously requested changes Feb 7, 2024
View reviewed changes
Copy link
Contributor

@pyphilia pyphilia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR!

Some feedbacks on the design:

  • I would have only "Type" in the label of the select, Filter by type is a bit long?
  • I think the checkboxes in the select are not necessary

src/components/common/MoveButton.tsx Outdated Show resolved Hide resolved
src/components/common/MoveButton.tsx Outdated Show resolved Hide resolved
src/components/main/CopyButton.tsx Outdated Show resolved Hide resolved
src/components/main/CreateShortcutButton.tsx Outdated Show resolved Hide resolved
vite.config.ts Outdated Show resolved Hide resolved
src/langs/fr.json Outdated Show resolved Hide resolved
src/utils/itemSelection.ts Outdated Show resolved Hide resolved
src/components/common/SelectTypes.tsx Outdated Show resolved Hide resolved
src/components/common/SelectTypes.tsx Outdated Show resolved Hide resolved
src/components/common/SelectTypes.tsx Outdated Show resolved Hide resolved
@ReidyT ReidyT requested a review from pyphilia February 7, 2024 13:46
spaenleh
spaenleh approved these changes Feb 9, 2024
View reviewed changes
Copy link
Member

@spaenleh spaenleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good !

src/components/common/MoveButton.tsx Show resolved Hide resolved
src/components/common/SelectTypes.tsx Outdated Show resolved Hide resolved
src/components/common/SelectTypes.tsx Outdated Show resolved Hide resolved
src/components/main/CopyButton.tsx Outdated Show resolved Hide resolved
src/components/main/CopyButton.tsx Outdated Show resolved Hide resolved
src/components/main/CopyButton.tsx Outdated Show resolved Hide resolved
src/components/main/ItemMenu.tsx Outdated Show resolved Hide resolved
src/components/pages/FavoriteItemsScreen.tsx Show resolved Hide resolved
ReidyT added 14 commits February 9, 2024 11:27
@ReidyT
feat: hide none-folder in the move modal
04a0ac0
@ReidyT
feat: filter children in hook and update copy button to remove CopyCo…
be28ca5 
…ntext
@ReidyT
feat: filter children by folders using the hook
d776a50 
- remove CreateShortcutModalContext and TreeModal
- encapsulate the shortcut logic in CreateShortcutButton
@ReidyT
fix(test): update create shorcut and copy item tests to works with ne…
33e902c 
…w modal
@ReidyT
fix: update createShortcut to handle undefined and add translations
eba5910
@ReidyT
feat: add select item filter (not working yet)
cd11912
@ReidyT
feat: use filter context and filter homepage and children
434a7a8
@ReidyT
feat: filter all items view by type using array's filter method
d10b8a7
@ReidyT
feat: update showonlyme checkbox to switch
7fcc54e
@ReidyT
fix: refetch queries on mount and update selection modal
dab77ba
@ReidyT
feat: use query-client 2.5.0 and filter children with array's filter
40b6329
@ReidyT
chore: improve code according to code review
0e70a67 
- remove checkbox in SelectTypes
- shorten label 'Filter by type' to 'Type'
- remove unnecessary code and comments
@ReidyT
chore: disable padding and gutters on MenuItem
1def210
@ReidyT
chore: improve code from code review
aa11077 
- reset itemIds in move and copy button on close
- improve imports in SelectTypes
- set isDisabled optional in ItemSelectionModal
@ReidyT ReidyT force-pushed the 606-children-item-by-type branch from 68f50e3 to 208bf81 Compare February 9, 2024 10:35
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 9, 2024

Quality Gate Passed Quality Gate passed

Issues
8 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@ReidyT ReidyT merged commit d11d13f into main Feb 9, 2024
4 checks passed
@github-actions github-actions bot mentioned this pull request Feb 9, 2024
Merged
@ReidyT ReidyT deleted the 606-children-item-by-type branch February 9, 2024 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spaenleh spaenleh spaenleh approved these changes

@pyphilia pyphilia Awaiting requested review from pyphilia

Assignees

@ReidyT ReidyT

Labels
v2.7.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ReidyT @pyphilia @spaenleh