Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: hide none-folder in the move modal #984

Merged
merged 3 commits into from
Feb 2, 2024
Merged

feat: hide none-folder in the move modal #984

merged 3 commits into from
Feb 2, 2024

Conversation

ReidyT
Copy link
Contributor

@ReidyT ReidyT commented Jan 31, 2024

  • Use the filter by types in the useAccessibleItems hooks in RootNavigationTree and AccessibleNavigation.
  • Use filter array methods on data of useChildren hook in ChildrenNavigationTree.

@ReidyT ReidyT added the feature New feature or request label Jan 31, 2024
@ReidyT ReidyT requested review from pyphilia and spaenleh January 31, 2024 12:44
@ReidyT ReidyT self-assigned this Jan 31, 2024
@ReidyT ReidyT force-pushed the 787-accessible-item-by-type branch from 4974f6d to 80adbae Compare February 1, 2024 14:01
pyphilia
pyphilia approved these changes Feb 2, 2024
View reviewed changes
Copy link
Contributor

@pyphilia pyphilia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚴‍♀️

package.json Outdated Show resolved Hide resolved
@ReidyT ReidyT force-pushed the 787-accessible-item-by-type branch from 80adbae to 5d4b9b4 Compare February 2, 2024 13:05
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 2, 2024

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

1 New issue
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@ReidyT ReidyT merged commit dbe6886 into main Feb 2, 2024
4 checks passed
@ReidyT ReidyT deleted the 787-accessible-item-by-type branch February 2, 2024 13:45
@github-actions github-actions bot mentioned this pull request Feb 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spaenleh spaenleh spaenleh approved these changes

@pyphilia pyphilia pyphilia approved these changes

Assignees

@ReidyT ReidyT

Labels
feature New feature or request v2.7.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ReidyT @pyphilia @spaenleh