Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: default route and conventions for route screens #976

Merged
merged 3 commits into from
Feb 2, 2024
Merged

fix: default route and conventions for route screens #976

merged 3 commits into from
Feb 2, 2024

Conversation

spaenleh
Copy link
Member

  • fix: update main component and cleanup
  • fix: uniformize routes and add 'real' fallback route

@spaenleh spaenleh self-assigned this Jan 26, 2024
@spaenleh spaenleh added the bug 🪲 Something isn't working label Jan 26, 2024
@spaenleh spaenleh marked this pull request as ready for review February 2, 2024 07:22
pyphilia
pyphilia approved these changes Feb 2, 2024
View reviewed changes
Copy link
Contributor

@pyphilia pyphilia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚴

package.json Outdated Show resolved Hide resolved
src/components/Root.tsx Outdated Show resolved Hide resolved
src/components/context/LayoutContext.tsx Outdated Show resolved Hide resolved
src/components/context/LayoutContext.tsx Outdated Show resolved Hide resolved
src/components/context/LayoutContext.tsx Outdated Show resolved Hide resolved
src/components/context/LayoutContext.tsx Outdated Show resolved Hide resolved
src/components/context/LayoutContext.tsx Outdated Show resolved Hide resolved
src/components/file/FileUploader.tsx Outdated Show resolved Hide resolved
src/components/main/Main.tsx Outdated Show resolved Hide resolved
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 2, 2024

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

4 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@spaenleh spaenleh merged commit eede60a into main Feb 2, 2024
4 checks passed
@github-actions github-actions bot mentioned this pull request Feb 2, 2024
Merged
@spaenleh spaenleh deleted the uniformize-routes branch February 2, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pyphilia pyphilia pyphilia approved these changes

@LinaYahya LinaYahya Awaiting requested review from LinaYahya

@ReidyT ReidyT Awaiting requested review from ReidyT

Assignees

@spaenleh spaenleh

Labels
bug 🪲 Something isn't working v2.6.3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@spaenleh @pyphilia