Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update main component and cleanup #968

Merged
merged 6 commits into from
Jan 31, 2024
Merged

Conversation

spaenleh
Copy link
Member

In this PR:

  • update the main component
  • cleanup some of the logic and components below the main component

@spaenleh spaenleh self-assigned this Jan 26, 2024
@spaenleh spaenleh added the feature New feature or request label Jan 26, 2024
@spaenleh spaenleh force-pushed the update-main-component branch from 1b04445 to 6a67054 Compare January 29, 2024 14:49
@spaenleh spaenleh marked this pull request as ready for review January 29, 2024 14:50
@spaenleh spaenleh force-pushed the update-main-component branch from a56dc59 to 791e7bf Compare January 30, 2024 12:02
Copy link
Contributor

@ReidyT ReidyT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Contributor

@pyphilia pyphilia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🌳

src/langs/fr.json Outdated Show resolved Hide resolved
Co-authored-by: Kim Lan Phan Hoang <[email protected]>
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@spaenleh spaenleh merged commit 1b38c24 into main Jan 31, 2024
4 checks passed
@spaenleh spaenleh deleted the update-main-component branch February 2, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request v2.6.2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants