Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update crop modal #966

Merged
merged 8 commits into from
Jan 29, 2024
Merged

fix: update crop modal #966

merged 8 commits into from
Jan 29, 2024

Conversation

spaenleh
Copy link
Member

@spaenleh spaenleh commented Jan 23, 2024 •
edited
Loading

TODO: merge UI and QueryClient PRs before !

In this PR:

  • cleanup cy.wait in tests
  • cleanup menuSelector var declaration that could be inlined
  • fix accessible search test flake
  • update crop modal to use newest version of the library and use PNG as the blob format

@spaenleh spaenleh self-assigned this Jan 26, 2024
@spaenleh spaenleh added bug 🪲 Something isn't working improvement labels Jan 26, 2024
@spaenleh spaenleh marked this pull request as ready for review January 29, 2024 07:48
pyphilia
pyphilia approved these changes Jan 29, 2024
View reviewed changes
Copy link
Contributor

@pyphilia pyphilia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice clean up!! 🐸

cypress/e2e/item/home/home.cy.ts Outdated Show resolved Hide resolved
src/components/common/CropModal.tsx Show resolved Hide resolved
src/components/common/CropModal.tsx Outdated Show resolved Hide resolved
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
2.1% Duplication on New Code

See analysis details on SonarCloud

@spaenleh spaenleh merged commit 5b15fb7 into main Jan 29, 2024
4 checks passed
@spaenleh spaenleh deleted the update-react-crop branch January 29, 2024 14:27
@github-actions github-actions bot mentioned this pull request Jan 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LinaYahya LinaYahya LinaYahya approved these changes

@pyphilia pyphilia pyphilia approved these changes

@ReidyT ReidyT Awaiting requested review from ReidyT

Assignees

@spaenleh spaenleh

Labels
bug 🪲 Something isn't working improvement v2.6.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@spaenleh @pyphilia @LinaYahya