Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: filter memberships for same member to render highest permission only #936

Merged
merged 1 commit into from
Jan 22, 2024

Conversation

LinaYahya
Copy link
Contributor

closes #729

@LinaYahya LinaYahya requested a review from pyphilia January 10, 2024 13:25
@LinaYahya LinaYahya self-assigned this Jan 10, 2024
src/components/item/sharing/ItemSharingTab.tsx Outdated Show resolved Hide resolved
@pyphilia pyphilia self-requested a review January 15, 2024 09:50
Copy link
Contributor

@pyphilia pyphilia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oups wrong button aha

@LinaYahya LinaYahya requested a review from pyphilia January 17, 2024 10:32
Copy link
Member

@spaenleh spaenleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I just provide some comments.

src/components/item/sharing/ItemSharingTab.tsx Outdated Show resolved Hide resolved
src/components/item/sharing/ItemSharingTab.tsx Outdated Show resolved Hide resolved
@spaenleh spaenleh force-pushed the 729-fix-duplicate-membership branch from c634bb0 to 14e9b6d Compare January 22, 2024 07:47
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@pyphilia pyphilia merged commit 8cf22c2 into main Jan 22, 2024
4 checks passed
@pyphilia pyphilia deleted the 729-fix-duplicate-membership branch January 22, 2024 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Duplicate membership in child item
3 participants