Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: move menu items tree #910

Merged
merged 28 commits into from
Jan 12, 2024
Merged

build: move menu items tree #910

merged 28 commits into from
Jan 12, 2024

Conversation

LinaYahya
Copy link
Contributor

@LinaYahya LinaYahya commented Dec 6, 2023

Build move menu items tree to not using mui/ tree view, Basically the user will have a home as a root of the menu which contains own and shared items,
For every folder that has children within there will be an arrow to let the user navigate to this item.

image

@LinaYahya LinaYahya self-assigned this Dec 12, 2023
@LinaYahya LinaYahya requested a review from pyphilia December 12, 2023 13:55
Copy link
Contributor

@pyphilia pyphilia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The modal tree is quite complex, I'd like more explanation and I'll review again. Thanks! 🎄

src/components/common/MoveButton.tsx Outdated Show resolved Hide resolved
src/components/common/MoveButton.tsx Outdated Show resolved Hide resolved
src/components/common/MoveButton.tsx Outdated Show resolved Hide resolved
src/components/common/MoveButton.tsx Outdated Show resolved Hide resolved
src/components/main/MoveTreeModal.tsx Outdated Show resolved Hide resolved
src/components/main/RowMenu.tsx Outdated Show resolved Hide resolved
src/components/main/RowMenu.tsx Outdated Show resolved Hide resolved
src/components/main/RowMenu.tsx Outdated Show resolved Hide resolved
src/components/main/RowMenu.tsx Outdated Show resolved Hide resolved
src/langs/en.json Outdated Show resolved Hide resolved
src/components/main/MoveTreeModal.tsx Outdated Show resolved Hide resolved
src/components/main/MoveTreeModal.tsx Outdated Show resolved Hide resolved
src/components/main/MoveTreeModal.tsx Outdated Show resolved Hide resolved
scroll="paper"
>
<DialogTitle id={dialogId}>{title}</DialogTitle>
<DialogContent sx={{ height: '250px' }}>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about this?

src/components/main/MoveTreeModal.tsx Outdated Show resolved Hide resolved
src/components/main/MoveTreeModal.tsx Outdated Show resolved Hide resolved
src/components/main/MoveTreeModal.tsx Outdated Show resolved Hide resolved
src/components/main/RootTreeModal.tsx Outdated Show resolved Hide resolved
@pyphilia pyphilia merged commit f014f13 into main Jan 12, 2024
3 checks passed
@pyphilia pyphilia deleted the 857-move-modal branch January 12, 2024 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants