Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid multiple library links in short links #896

Merged
merged 3 commits into from
Dec 6, 2023

Conversation

ReidyT
Copy link
Contributor

@ReidyT ReidyT commented Dec 5, 2023

See the issue #895 for more information.

@ReidyT ReidyT requested a review from spaenleh December 5, 2023 10:28
@ReidyT ReidyT self-assigned this Dec 5, 2023
@ReidyT ReidyT linked an issue Dec 5, 2023 that may be closed by this pull request
- avoid useless states or useEffects
- construct the short links using map function
@ReidyT ReidyT linked an issue Dec 6, 2023 that may be closed by this pull request
@ReidyT ReidyT changed the title fix: reset the item platforms to avoid multiple library links fix: avoid multiple library links in short links Dec 6, 2023
Copy link
Member

@spaenleh spaenleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, just a suggestion to use the platform as the key.

@ReidyT ReidyT requested a review from spaenleh December 6, 2023 14:31
@ReidyT ReidyT merged commit 226673c into main Dec 6, 2023
3 checks passed
@ReidyT ReidyT deleted the 895-short-link-lib-displayed-twice branch December 6, 2023 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants