feat: use accessible items on home #887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LinaYahya
approved these changes
Dec 4, 2023
pyphilia
force-pushed
the
886-accessible-items
branch
from
4b31fed to
fb63535
Compare
spaenleh
requested changes
Dec 19, 2023
src/components/main/ItemsToolbar.tsx
Outdated
There was a problem hiding this comment.
Not sure the ShowOnly me should be defined here, will it be shown on all folders ? or is this just a "home" thing ?
There was a problem hiding this comment.
Indeed it's a bit too nested in the components. But if I want to place it where I want + not break the other tables I have to edit a lot of files. I think a better move is to do that while changing the tables.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to @LinaYahya previous work this PR was really easy to do. Instead of applying the pagination on own items, I've done it on another endpoint to avoid losing some features (copy, move, navigation that show the full list of own items).
In addition pagination and search are done in the backend (only for home page).
By default I've set
trueto show only items created by us, but probably it's better to set it tofalseto reveal the full potential of the page. What do you think @juancarlosfarah @dgillet @swouf @LinaYahya @spaenleh ?Reminder: we have to merge own and shared items because some edge cases prevent you to find your items (an item you created but is not a root cannot be displayed)
TODO:
close #886
close #794