Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update app cards to list in new item modal #844

Merged
merged 6 commits into from
Oct 24, 2023
Merged

feat: update app cards to list in new item modal #844

merged 6 commits into from
Oct 24, 2023

Conversation

pyphilia
Copy link
Contributor

Screenshot 2023-10-23 at 15 54 23 Screenshot 2023-10-23 at 15 54 50

close #835

@pyphilia pyphilia requested a review from spaenleh October 23, 2023 13:55
@pyphilia pyphilia self-assigned this Oct 23, 2023
@pyphilia pyphilia temporarily deployed to development October 23, 2023 13:55 — with GitHub Actions Inactive
@pyphilia pyphilia temporarily deployed to development October 23, 2023 14:09 — with GitHub Actions Inactive
spaenleh
spaenleh reviewed Oct 23, 2023
View reviewed changes
Copy link
Member

@spaenleh spaenleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice changes ! I would like a more polished design but I see you are still iterating 😄

src/components/item/form/AppForm.tsx Show resolved Hide resolved
src/components/item/form/AppForm.tsx Outdated Show resolved Hide resolved
spaenleh
spaenleh approved these changes Oct 23, 2023
View reviewed changes
Copy link
Member

@spaenleh spaenleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me.

For now using white as the background is the best, but in the end we should have all the app icons be on a color background and use white lines (like the Text Input one), so we will be able to add rounded corners etc

@pyphilia pyphilia merged commit 740d567 into main Oct 24, 2023
3 checks passed
@pyphilia pyphilia deleted the 835-app-list branch October 24, 2023 09:23
@github-actions github-actions bot mentioned this pull request Oct 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spaenleh spaenleh spaenleh approved these changes

Assignees

@pyphilia pyphilia

Labels
v1.11.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Iterate over the design of the app list cards
2 participants
@pyphilia @spaenleh