Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: cant edit an item twice without reloading #842

Merged
merged 7 commits into from
Oct 25, 2023
Merged

fix: cant edit an item twice without reloading #842

merged 7 commits into from
Oct 25, 2023

Conversation

spaenleh
Copy link
Member

@spaenleh spaenleh commented Oct 23, 2023 •
edited
Loading

In this PR:

@spaenleh spaenleh linked an issue Oct 23, 2023 that may be closed by this pull request
Can't edit an item twice without reloading #809
Closed
@spaenleh spaenleh temporarily deployed to development October 23, 2023 10:49 — with GitHub Actions Inactive
@spaenleh spaenleh self-assigned this Oct 23, 2023
@spaenleh spaenleh added the bug 🪲 Something isn't working label Oct 23, 2023
@spaenleh spaenleh force-pushed the 809-cant-edit-an-item-twice-without-reloading branch from 44bf228 to b1613b4 Compare October 23, 2023 12:32
@LinaYahya LinaYahya marked this pull request as ready for review October 23, 2023 12:37
@LinaYahya LinaYahya marked this pull request as draft October 23, 2023 12:37
@spaenleh spaenleh force-pushed the 809-cant-edit-an-item-twice-without-reloading branch 2 times, most recently from 05d993d to d9261ed Compare October 24, 2023 09:10
@spaenleh spaenleh marked this pull request as ready for review October 25, 2023 04:28
@spaenleh spaenleh force-pushed the 809-cant-edit-an-item-twice-without-reloading branch from d9261ed to 116059b Compare October 25, 2023 04:37
@spaenleh spaenleh requested a review from pyphilia October 25, 2023 04:42
@spaenleh spaenleh force-pushed the 809-cant-edit-an-item-twice-without-reloading branch from 116059b to da8db4b Compare October 25, 2023 05:25
@spaenleh spaenleh force-pushed the 809-cant-edit-an-item-twice-without-reloading branch from da8db4b to cb04475 Compare October 25, 2023 05:41
@spaenleh spaenleh temporarily deployed to development October 25, 2023 06:27 — with GitHub Actions Inactive
pyphilia
pyphilia approved these changes Oct 25, 2023
View reviewed changes
Copy link
Contributor

@pyphilia pyphilia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added minor comments! Feel free to report if we're tight on time.

src/components/common/EditButton.tsx Outdated Show resolved Hide resolved
src/components/item/form/EditModalWrapper.tsx Outdated Show resolved Hide resolved
src/components/item/form/EditModalWrapper.tsx Outdated Show resolved Hide resolved
src/components/item/form/EditModalWrapper.tsx Outdated Show resolved Hide resolved
src/components/item/form/FileForm.tsx Outdated Show resolved Hide resolved
src/langs/fr.json Outdated Show resolved Hide resolved
@spaenleh spaenleh merged commit 9098142 into main Oct 25, 2023
3 checks passed
@spaenleh spaenleh deleted the 809-cant-edit-an-item-twice-without-reloading branch October 25, 2023 09:03
@github-actions github-actions bot mentioned this pull request Oct 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pyphilia pyphilia pyphilia approved these changes

Assignees

@spaenleh spaenleh

Labels
bug 🪲 Something isn't working v1.11.0
Projects
None yet
Milestone
No milestone
2 participants
@spaenleh @pyphilia