Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: create a dialog to downgrade own membership #822

Merged
merged 8 commits into from
Oct 24, 2023

Conversation

LinaYahya
Copy link
Contributor

No description provided.

Copy link
Member

@spaenleh spaenleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌷 Thank you for this change.

I understand dis-allowing a user to edit their own permission is the safest way to ensure they do not loose access. But I think we should let users downgrade their permission if they want.

Just to recap:

  • users that can edit memberships: only admins
  • users that could downgrade their membership: only admins

Currently with the flick of a select you can remove your membership, it is too easy can have destructive and unforgiving consequences. I think we should introduce the dialog as a way to warn the user that they might do something that they can not undo. So I would change it so that they can downgrade their permission but only after having seen the dialog and accepting the consequences.

Also important is that they should not be able to downgrade their permission if they are the last admin.

@LinaYahya LinaYahya requested a review from spaenleh October 20, 2023 09:09
Copy link
Member

@spaenleh spaenleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just two comments about the version, otherwise it is good to merge once you have updated them.

package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@LinaYahya LinaYahya merged commit 7baf7b8 into main Oct 24, 2023
3 checks passed
@spaenleh spaenleh deleted the 821-downgrade-permission-diloag branch October 25, 2023 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants