feat: shorten item link #793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spaenleh
approved these changes
Sep 27, 2023
There was a problem hiding this comment.
Thank you for this PR ! 🎉
I was able to test locally and it all looks like it works.
Just a thought, maybe we want to use some sort of redirection when accessing a short url to expand it to the long form ? My point would be that if we have 2 different urls for the same page it could confuse users ?
…320-shorten-item-link
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
shorten item link on sharing using short-uuid for both player and builder sides. as well as to decrypt shortened uuid using params hook from graasp-ui.
closes #320