Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix create document validation #788

Merged
merged 2 commits into from
Sep 13, 2023
Merged

fix create document validation #788

merged 2 commits into from
Sep 13, 2023

Conversation

LinaYahya
Copy link
Contributor

relates #787

@LinaYahya LinaYahya requested a review from pyphilia September 8, 2023 12:15
@LinaYahya LinaYahya self-assigned this Sep 8, 2023
@pyphilia
Copy link
Contributor

Sorry, I think we weren't on the same page, but we actually wanted to avoid saving empty documents. Maybe this PR is not necessary then? Let me know if I missed something.

@LinaYahya
Copy link
Contributor Author

@pyphilia
The thing is I've already tried to create a document with an empty description and it always succeded, What's going right now is that we have an initial state with an inactive button, if we try to just get a dirty description input (meaning by try to add some text and delete all) then we will get an active add button!
and I think this is wired somehow!

@pyphilia pyphilia linked an issue Sep 13, 2023 that may be closed by this pull request
Create Document Form Validation #787
Closed
@pyphilia pyphilia merged commit 09a317e into main Sep 13, 2023
@pyphilia pyphilia deleted the 787-create-document-validation branch September 13, 2023 07:48
@github-actions github-actions bot mentioned this pull request Sep 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pyphilia pyphilia pyphilia approved these changes

Assignees

@LinaYahya LinaYahya

Labels
v1.10.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create Document Form Validation
2 participants
@LinaYahya @pyphilia