Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: prevent adding new item blank spaces #784

Merged
merged 3 commits into from
Sep 12, 2023
Merged

fix: prevent adding new item blank spaces #784

merged 3 commits into from
Sep 12, 2023

Conversation

LinaYahya
Copy link
Contributor

this fix was made to disable create new item button for whitespaces titles
relates #781

@LinaYahya LinaYahya requested a review from pyphilia September 7, 2023 14:13
@LinaYahya LinaYahya linked an issue Sep 7, 2023 that may be closed by this pull request
Fix adding new Item name with blank spaces #781
Closed
pyphilia
pyphilia approved these changes Sep 8, 2023
View reviewed changes
Copy link
Contributor

@pyphilia pyphilia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! It's perfect for me!
It might be interesting to add another test for document let's say, to verify that the name check also apply to other item types.

cypress/e2e/item/create/createFolder.cy.ts Outdated Show resolved Hide resolved
@LinaYahya LinaYahya merged commit 0f02a64 into main Sep 12, 2023
@github-actions github-actions bot mentioned this pull request Sep 12, 2023
Merged
@spaenleh spaenleh deleted the 781-fix-new-item-blank-spaces branch October 6, 2023 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pyphilia pyphilia pyphilia approved these changes

Assignees
No one assigned
Labels
v1.10.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix adding new Item name with blank spaces
2 participants
@LinaYahya @pyphilia